Skip to content

windows: add virtual key codes and console input consts #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

windows: add virtual key codes and console input consts #226

wants to merge 1 commit into from

Conversation

aymanbagabas
Copy link
Contributor

This adds console input related key codes and consts

@gopherbot
Copy link
Contributor

This PR (HEAD: 7db5f02) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/621495.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ayman Bagabas:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@aymanbagabas aymanbagabas mentioned this pull request Oct 21, 2024
Closed
@aymanbagabas
Copy link
Contributor Author

Hey @alexbrainman, can we get this in? This only contains key and input codes.

@gopherbot
Copy link
Contributor

Message from Ayman Bagabas:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from abner chenc:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-03-12T03:31:44Z","revision":"8643fd8114b1b7f7c24cfd4756da624cf1212fd6"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from abner chenc:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alex Brainman:

Patch Set 1:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@aymanbagabas aymanbagabas force-pushed the windows-coninput-consts branch 2 times, most recently from 5eab44a to 8e534f4 Compare April 20, 2025 09:44
@gopherbot
Copy link
Contributor

This PR (HEAD: 8e534f4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/621495.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Ayman Bagabas:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@aymanbagabas
windows: add virtual key codes and console input consts
8e534f4 
This adds console input related key codes and consts
@gopherbot
Copy link
Contributor

Message from Alex Brainman:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-04-21T08:00:07Z","revision":"126dbf2db2f2ade2506f9aac5066bff0433a1e98"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alex Brainman:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alex Brainman:

Patch Set 2: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Junyang Shao:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 22, 2025
@aymanbagabas @gopherbot
windows: add virtual key codes and console input consts
8e9e046 
This adds console input related key codes and consts

Change-Id: I8ebd76995a2c9ddd150cf04890a9e5053841fcab
GitHub-Last-Rev: 8e534f4
GitHub-Pull-Request: #226
Reviewed-on: https://go-review.googlesource.com/c/sys/+/621495
Reviewed-by: Junyang Shao <[email protected]>
Auto-Submit: Michael Pratt <[email protected]>
Reviewed-by: Michael Pratt <[email protected]>
Reviewed-by: Alex Brainman <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
@gopherbot
Copy link
Contributor

Message from Michael Pratt:

Patch Set 2: Auto-Submit+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/621495 has been merged.

@gopherbot gopherbot closed this Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aymanbagabas @gopherbot